edgarcosta / hilbertmodularforms

Mockup implementation of Hilbert Modular Forms
BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

Examples and verification using hold syntax #65

Open edgarcosta opened 5 years ago

edgarcosta commented 5 years ago

At the moment I can't run the following files:

Looks like that for most of them should be a simple adaptation to the new syntax for HMFSpace.

In either case, we should try to update the syntax on these files whenever we change the syntax somewhere else, otherwise, they aren't very good examples...

edgarcosta commented 5 years ago

I manage to get examples/can_ring_example.m to run, but now is taking forever to get anywhere .... @samueltripp told me it should take only a couple of minutes, but this has been running for more than 10 min and I only got this:

Level: 2      Generators 1  Relations 0
Graded ring of Hilbert modular forms over Quadratic Field with defining polynomial x^2 - 13 over the Rational Field with precision 100
Level: 4      Generators 1  Relations 0

Update:

Loading file "examples/can_ring_example.m"
Loading "config.m"
Level: 2      Generators 1  Relations 0
Graded ring of Hilbert modular forms over Quadratic Field with defining polynomial x^2 - 13 over the Rational Field with precision 100
Level: 4      Generators 1  Relations 0
Level: 6      Generators 2  Relations 0
Level: 8      Generators 1  Relations 0
Time: 4372.740

In file "examples/can_ring_example.m", line 13, column 25:
>> time g1, r1 := Relations(M, g, r, 20);
                           ^
Runtime error in 'Relations': Bad argument types
Argument types given: ModFrmHilDGRng, Assoc, Assoc, RngIntElt

Anyhow, I also learned that issue is indeed we changed the meaning of prec and prec = 100 is way too high.

Triple Update: examples/can_ring_example.m has been fixed

edgarcosta commented 5 years ago

tests.m and usage.m are running as expected. I didn't try to fix the rest, but at least we have now a place to look at how to use our code.