edgardmessias / glpi-singlesignon

GNU General Public License v3.0
68 stars 51 forks source link

Callback URL is using http instead of https #51

Open muzzol opened 1 year ago

muzzol commented 1 year ago

I just installed master version and when everything is configured the Callback URL appears without https:

http://XXX.XXX/glpi10/plugins/singlesignon/front/callback.php/provider/1

instead of

https://XXX.XXX/glpi10/plugins/singlesignon/front/callback.php/provider/1

is this value hardcoded somewhere?

muzzol commented 1 year ago

I've debugged a little bit more and the problem is that the plugin don't honour base URL configured in general configuration.

Is that by design?

eramos13 commented 1 year ago

you managed to correct http and https?

I've debugged a little bit more and the problem is that the plugin don't honour base URL configured in general configuration.

Is that by design?

achaveztematica commented 11 months ago

hello, is there any news about it? plugin url callback is defined in http but azure ad require an https callback uri

muzzol commented 11 months ago

In my case the problem was that I was using a proxypass and the call somewhat was registered as http instead of https, so even if using https the callback was rewrited as http.

I changed some configuration on my proxy and now everything works.

the problem remains anyway, so I won't close this issue, but maybe it could be renamed to a feature request like: Force https on callbacks

let's wait for some admin to peak

colimberk commented 6 months ago

Hi, friend. Could you please share the changes you made to the proxy? Because I also have it in a proxy and I am having the same problem. Thank you. Excuse my English (google)