search

edgardmessias / vscode.override-mark

Show a gutter icon when has a implement/override method/property in javascript or typescript.
https://marketplace.visualstudio.com/items?itemName=EdgardMessias.override-mark
MIT License
2 stars 5 forks source link

Extension makes VsCode very slow #127

Open PonyOny opened 3 years ago

PonyOny commented 3 years ago

When I have the extension enabled vscode is very slow, the autocomplete features are very slow to complete and all is drastically very slow, even saving a file (Ctrl + S) takes some seconds, disabling the extension makes everything work as expected, tested on multiple computers.

forivall commented 3 years ago

I presume this is because it's parsing the code in the extension host instead of a language service. If i can figure out how to run it in a language service quickly, i'll submit a PR.

forivall commented 3 years ago

Started initial work on using a language service plugin here https://github.com/forivall/vscode.override-mark/commit/bec1e610dd99f5f01ac3c1dfe5e8b5c0adb68ee9 -- i'm looking at angular's lsp and figuring out how to call that custom lsp command that the wip plugin provides.

edgardmessias commented 3 years ago

@forivall , big thanks, I will be grateful for that

forivall commented 3 years ago

My plan is to use techniques from https://github.com/hediet/hediet-ts-refactoring-lsp (except i'll handshake using configurePlugin see instead of executeCompletionProviders) -- or see if i can return custom highlight types (for override and implement) from executeDocumentSymbolProvider

edgardmessias commented 3 years ago

@forivall it will be wonderful.

What you think about the minimal VSCode requirement? Shoud us increase that?

forivall commented 3 years ago

I'll see when i actually work on the implementation -- i just wanted to dump my research / open tabs from the weekend, so i can resume work on this later. For now, it's on pause as i work on day job work 😄