search

edgarriba / DeepRosetta

An universal deep learning models conversor
Other
141 stars 39 forks source link

Initial Caffe Importer #9

Closed gcucurull closed 8 years ago

gcucurull commented 8 years ago

It still doesn't load the caffemodel to our custom format, but it is a prof of concept of how to open a caffemodel and get the information and parameters for each layer.

edgarriba commented 8 years ago

@gcucurull The tests are failing because we use CaffeImporter as dummy case. Could you switch them off? Ideally we should create a DummyCaffeImporter for testing

gcucurull commented 8 years ago

Ok, I'll change it later, I didn't notice it when I sent the PR.

gcucurull commented 8 years ago

I have added the DummyImporter, but the tests are still failing, because there is no DummyExporter I assume. I feel like this is outside the scope of this PR, the tests should not be using CaffeImporter until we really want to test it, the same way as we are not still testing Lasagne or Matconvnet.

gcucurull commented 8 years ago

I have "disabled" the testing in a dirty way. I know it is not the right thing to do, but it is outside the scope of this PR, so I think this PR should be merged and then fix the tests in another PR.

edgarriba commented 8 years ago

@gcucurull Is it ready to merge?

gcucurull commented 8 years ago

I guess it is, it's not the final version but it is a basic Caffe Importer to extend

edgarriba commented 8 years ago

oki! I'll merge it