edge-ml / ml

machine learning component
1 stars 0 forks source link

Implement time-based windowing #35

Closed tk-king closed 10 months ago

tk-king commented 1 year ago
omeryagmurlu commented 1 year ago

Apparently, the dtype=object approach was working without any problems, and I had made a mistake during implementation. We don't need any custom classes for window.

We still need to figure out how to decouple (or couple) windowing and feature extraction though, NoFeatureExtractor still doesn't work with varying window sizes, and no custom window class would help because sklearn doesn't work with varying length features anyway.