edge20200 / Only-Uploader

3 stars 2 forks source link

Repack specials fix #6

Open noxxusnx opened 5 months ago

noxxusnx commented 5 months ago

If a special episode is a repack, the title of the episode is not included, just the "REPACK" tag

noxxusnx commented 5 months ago

This appears to be an issue in the guessit library that this script uses to extract video information from a file name.

You can replicate with setting this up:

from guessit import guessit

file_name_original = "Total.Forgiveness.S00E01.Grant.OBrien.Its.All.Love.Full.Stand.up.Set.1080p.DRPO.WEBRip.x265.AAC.2.0-NOXXUS.mkv"
file_name_repack = "Total.Forgiveness.S00E01.REPACK.Grant.OBrien.Its.All.Love.Full.Stand.up.Set.1080p.DRPO.WEBRip.x265.AAC.2.0-NOXXUS.mkv"

Then calling guessit(file_name_original) returns:

MatchesDict({'title': 'Total Forgiveness', 'season': 0, 'episode': 1, 'episode_title': 'Grant OBrien Its All Love Full Stand up Set', 'screen_size': '1080p', 'source': 'Web', 'other': 'Rip', 'video_codec': 'H.265', 'audio_codec': 'AAC', 'audio_channels': '2.0', 'release_group': 'NOXXUS', 'container': 'mkv', 'mimetype': 'video/x-matroska', 'type': 'episode'})

Then calling guessit(file_name_repack) returns:

MatchesDict({'title': 'Total Forgiveness', 'season': 0, 'episode': 1, 'other': ['Proper', 'Rip'], 'proper_count': 1, 'screen_size': '1080p', 'source': 'Web', 'video_codec': 'H.265', 'audio_codec': 'AAC', 'audio_channels': '2.0', 'release_group': 'NOXXUS', 'container': 'mkv', 'mimetype': 'video/x-matroska', 'type': 'episode'})

Noticeably no longer returning a value for episode_title

noxxusnx commented 5 months ago

Created an issue for this upstream here https://github.com/guessit-io/guessit/issues/775

noxxusnx commented 1 month ago

Created a PR in the upstream library to fix this https://github.com/guessit-io/guessit/pull/788