search

edgecase / bird-wave

An api for eBird data
0 stars 0 forks source link

cljsjs! also upgrades cljs, om and core.async #27

Closed tennety closed 9 years ago

tennety commented 9 years ago

Removes react and d3 from cljsbuild config, adds cljsjs and requires.

Note: for d3, the cljs code still says js/d3 because the library itself is still loaded globally.

jxa commented 9 years ago

Is it an option to have d3 required into the namespace, or does the d3 library just force itself into global namespace? I'm just not that familiar with the cljsjs thing yet...

jxa commented 9 years ago

:+1:

tennety commented 9 years ago

Sorry @jxa , should have followed up sooner. So apparently anything cljsjs provides will still put itself in the global js namespace. The cljsjs/d3 thing is just the convenient way of specifying the dependency. If I said require [cljsjs/d3 :as d3], I still couldn't use just d3 in the code, it would be undeclared. This is true for any library provided by cljsjs.