Add D3 - Githubissues

edgecase / bird-wave

An api for eBird data

0 stars 0 forks source link

Add D3 #5

Closed tennety closed 10 years ago

tennety commented 10 years ago

Creating this pull request to track development on this branch. It could use a lot of cleanup. I'll update when it's ready to merge.

tennety commented 10 years ago

@Bestra @jxa Could I get you guys' eyes on this branch? I think that with a little bit of cleanup we can merge this in master. We have a working front-end!

Bestra commented 10 years ago

I've still gotta actually run your code, but I didn't see anything bad reading through. Great work! Now all I can resort to are non-source-related nitpicks :neckbeard:

I think we should start adding some of the generated files to the .gitignore, at least resources/public/javascript/ subdirectories (goog, clojure, cljs, bird_man). The files in there should stay since they represent some dependencies and configuration, but anything that's going to be overwritten by the build should be ignored to reduce noise on the diffs.
can you update the sample transactor properties with the ones you're using now? The file still mentions postgres but I believe you guys are both using h2.

jxa commented 10 years ago

For some reason it's not loading any data for me. I select the species but no request is made.

jxa commented 10 years ago

If I also move the month selection I do get data. Now I'm seeing migration! Nicely done!

tennety commented 10 years ago

@jxa Yeah, I changed it so that the slider is what makes the requests. It just looks at the current selected species and month and hits the appropriate URL.

I tried it with a full import this morning, and some of the eastern birds are still pretty slow, because of the density of counties, possibly. But it's significantly faster overall!

tennety commented 10 years ago

I totally agree on the gitignore. At the time, I wasn't sure what was safe to be ignored and what wasn't, but we definitely need something.

@bestra yes, I can check in the sample file for the properties we're using.

Bestra commented 10 years ago

I added a commit to remove the generated stuff. I think we'll actually need to modify the gitinore to keep the .js files at the root of the /resources/public/javascripts/ directory since those files are referenced in the main .js file.