edgecase / dieter

Asset pipeline ring middleware
134 stars 22 forks source link

Removing dependancy on fs lib #41

Closed DanThiffault closed 11 years ago

DanThiffault commented 11 years ago

I started by upgrading libraries for better compatibility with other libs. Ended up upgrading ring, reducing ring dependency to ring-core, and all together removing fs. The fs library is in a bit of flux right now: changing core namespace, removing functionality.

With what dieter was using it was pretty straightforward just to use Java File + core/io

pbiggar commented 11 years ago

Looks good except for the two minor things. Happy to merge as is if you think they're better as they are.

DanThiffault commented 11 years ago

Good catches, I was messing around with those while I was debugging. Undid those two changes.