edgecase / ghpreview

Preview Markdown files (such as a README) exactly how it will appear on Github
MIT License
27 stars 4 forks source link

Required dependencies not listed, not found #19

Closed gavinbeatty closed 10 years ago

gavinbeatty commented 10 years ago

html-pipeline does not have dependencies on many gems it requires in order to use some of its pipelines. This is mentioned in its https://github.com/jch/html-pipeline#dependencies section.

So it would seem ghpreview should add the required dependencies, as it knows what pipelines it is using. I have translated the following from html-pipeline's Gemfile's :test section:

gem.add_dependency 'github-linguist', '~> 2.6.2'
gem.add_dependency 'github-markdown', '~> 0.5'
if RUBY_VERSION < "1.9.2"
  gem.add_dependency 'sanitize', '>= 2', '< 2.0.4'
else
  gem.add_dependency 'sanitize', '~> 2.0'
end
gem.add_dependency 'gemoji', '~> 1.0'
gem.add_dependency 'rinku', '~> 1.7'
gem.add_dependency 'RedCloth', '~> 4.2.9'
gem.add_dependency 'escape_utils', '~> 0.3'

But I have had no luck with these with either ruby-1.9.3-p484 or ruby-2.0.0-p353. I had no gems previously installed (this is a fresh rvm install on OS X Mavericks).

adamlogic commented 10 years ago

@gavinbeatty Thanks for reporting this. Please install the latest and let me know if it works for you.

gavinbeatty commented 10 years ago

Installed cleanly with MacPorts libraries using:

gem install ghpreview -- \
  --with-opt-dir=/opt/local \
  --with-icu-dir=/opt/local --with-xml2-dir=/opt/local

Thanks!