search

edgecase / ghpreview

Preview Markdown files (such as a README) exactly how it will appear on Github
MIT License
27 stars 4 forks source link

CamoFilter, EmojiFilter and File.write #8

Closed banafederico closed 11 years ago

banafederico commented 11 years ago

1) html-pipeline filters now need some kind of parameters. Comment out filters that need the new context parameters for the time being. So we can still install and use.

2) File.write seems not to be there in 1.9.3? http://www.ruby-doc.org/core-1.9.3/File.html. Changed call to File::write for a working solution.

adamlogic commented 11 years ago

I'm definitely cool with killing the CamoFilter. It's not necessary for ghpreview. I'd like to keep EmojiFilter, but I'm not sure how. It requires an :asset_host option, and we're not hosting any of the emoji assets. Let's just kill them both for now.

adamlogic commented 11 years ago

Thanks!