edgecase / spotbox

Official jukebox of the EdgeCase lab
Other
13 stars 1 forks source link

Convert tabs to use Ember state machine #39

Closed agrieser closed 12 years ago

agrieser commented 12 years ago

Performance improvement, don't render things that aren't being shown

tonywok commented 12 years ago

I have a working version of this. I decided it was better off in a separate branch until I can get some code review having never worked with ember state managers.

The branch lives here: https://github.com/edgecase/spotbox/tree/tab_state_machine

known issues:

tonywok commented 12 years ago

I was able to get rid of the hack by creating the state manager without an initial state, then doing a goToState inside of the Spotbox.ready function.

I decided not to make a CollectionView of playlist items. I wouldn't mind if someone took a look at cleaning up the playlist tab though.

This has been merged into master.