search

edgedb / edgedb-cli

The EdgeDB CLI
https://www.edgedb.com/docs/cli/index
Apache License 2.0
165 stars 23 forks source link

fish shell support for the installer #673

Open geohuz opened 2 years ago

geohuz commented 2 years ago

It seems that installer script doesn't support fish shell profile?

elprans commented 2 years ago

Yes, we should add native support for fish profiles.

I use fish, but I don't set it as $SHELL and start it from .bashrc instead, so environment is picked up both by interactive fish and any bash scripts I run.

tailhook commented 2 years ago

Should we use fish_add_path https://github.com/rust-lang/rustup/issues/478#issuecomment-839537308, but only when running with $SHELL=fish. Or should we use drop a file into ~/.config/fish/conf.d/ (https://github.com/rust-lang/rustup/issues/478#issuecomment-284203225) ? So that even if someone uses multiple shells or will install fish later on, it still works?

elprans commented 2 years ago

I think those aren't exclusive? fish_add_path is just a more canonical way of doing set -gx PATH.

tailhook commented 2 years ago

I think those aren't exclusive? fish_add_path is just a more canonical way of doing set -gx PATH.

fish_add_path is persistent as far as I understand. So it isn't very useful to do both.