Add SERVER prefix to environment variable names

edgedb / edgedb-docker

Official Docker Image packaging for EdgeDB

83 stars 16 forks source link

Add SERVER prefix to environment variable names #22

Closed fmoor closed 3 years ago

fmoor commented 3 years ago

fixes https://github.com/edgedb/edgedb/issues/2643

This change disambiguates server environment variables from client environment variables.

fmoor commented 3 years ago

I didn't add SERVER to the database specific options. Is this what you had in mind @elprans?

elprans commented 3 years ago

I didn't add SERVER to the database specific options

All options should be prefixed. Please also add fallback to old vars and issue a deprecation warning in edbdocker_lookup_env_var

elprans commented 3 years ago

I've made some fixups to the patch and undeprecated the unprefixed HOST|PORT|PASSWORD variables, since those aren't ambiguous and make it easier to share values in compose.