search

edgedb / edgedb-docker

Official Docker Image packaging for EdgeDB
83 stars 16 forks source link

edgedb/edgedb:latest isn't latest #70

Closed midzdotdev closed 1 year ago

midzdotdev commented 1 year ago

Resubmitting after posting in the wrong repo: https://github.com/edgedb/edgedb/issues/4901

Hey guys, I think something's up with CI or Docker tags and I don't believe this would be intentional.

edgedb/edgedb:2 was uploaded Dec 16, 2022 at 6:13 pm. edgedb/edgedb:2.9 is references the same image.

edgedb/edgedb:latest was uploaded Nov 19, 2022 at 3:40 am.

I noticed when the :latest image wouldn't allow the /server/status/alive health check but did allow /server/status/ready. FWIW, I can confirm both of these health checks are present in :2 and :2.9.

If I had to take a guess, it would be something to do with this logic.

https://github.com/edgedb/edgedb/blob/a73a40d88dc9bc226509318f87d7f574abde74c8/.github/workflows/release.yml#L2265-L2267

Looking at the blame, this might be the suspect. https://github.com/edgedb/edgedb/commit/a41fbc3a2f457d475f2029236d4024ccff875085

Although that seems like it was merged at Nov 18, 2022, 5:17 AM GMT, but the :latest image was uploaded almost a day after. Maybe a manual tagging 🤷‍♂️

midzdotdev commented 1 year ago

Apparently the other repo is the correct one. Continuing in https://github.com/edgedb/edgedb/issues/4901.