search

edgedb / edgedb-js

The official TypeScript/JS client library and query builder for EdgeDB
https://edgedb.com
Apache License 2.0
514 stars 65 forks source link

Remove from object shape keys with value never #1051

Closed diksipav closed 4 months ago

diksipav commented 4 months ago

Hey, I am not sure if this is 100% what we need in order to fix #1037 .

It works okay with the test mentioned in the issue.

Screenshot 2024-07-05 at 18 39 56 Screenshot 2024-07-05 at 18 39 33
diksipav commented 4 months ago

Let's also add some tests to https://github.com/edgedb/edgedb-js/blob/master/integration-tests/lts/select.test.ts to prevent future regressions and to ensure this change has the desired effect like your screenshots.

I fix the test and added 2 more tests. Was't sure do we really need to test assignment and do we need to test it with bool prop so I added new prop to the Person anyway. I can remove it ofc if the test is redundant.