edgedb / edgedb-js

The official TypeScript/JS client library and query builder for EdgeDB
https://edgedb.com
Apache License 2.0
511 stars 65 forks source link

Cannot generate `edgeql-js` files with `@edgedb/generate@1.5.0` #947

Closed aroblast closed 6 months ago

aroblast commented 6 months ago

Describe the bug It seems the newest release of @edgedb/generate@1.5.0 is broken because of @iarna/toml.

Reproduction The edgeql-js generation command gives the following result:

$ npx @edgedb/generate edgeql-js --target=ts
node:internal/modules/cjs/loader:1152
  throw err;
  ^

Error: Cannot find module '@iarna/toml'
Require stack:
- /Users/XXXXXX/.npm/_npx/b55eec623338e3ca/node_modules/@edgedb/generate/dist/cli.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1149:15)
    at Module._load (node:internal/modules/cjs/loader:990:27)
    at Module.require (node:internal/modules/cjs/loader:1237:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (/Users/XXXXXX/.npm/_npx/b55eec623338e3ca/node_modules/@edgedb/generate/dist/cli.js:28:27)
    at Module._compile (node:internal/modules/cjs/loader:1378:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1437:10)
    at Module.load (node:internal/modules/cjs/loader:1212:32)
    at Module._load (node:internal/modules/cjs/loader:1028:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:142:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/XXXXXX/.npm/_npx/b55eec623338e3ca/node_modules/@edgedb/generate/dist/cli.js'
  ]
}

Node.js v21.6.2

Expected behavior The dbschema/edgeql-js should be generated w/o errors.

Versions

scotttrinh commented 6 months ago

Looking into this now, thanks for the report!

scotttrinh commented 6 months ago

@aroblast Thanks for the quick report! Fixed in 0.5.1 which is now published on npm.

aroblast commented 6 months ago

Thank you for reacting so quickly! Works fine for me now.