search

edgedb / edgedb-net

The official .NET client library for EdgeDB
https://edgedb.com
Apache License 2.0
82 stars 9 forks source link

fix connection phase ignoring server errors #41

Closed quinchs closed 1 year ago

quinchs commented 1 year ago

Summary

The binding doesn't propagate errors received from the server during the connection phase. If an error response is sent after a client handshake, the error is logged and the client continues to execute; disregarding the error.

Example flow:

13:19:08 - Debug: C->S: Client 1: ClientHandshake len: 50
13:19:08 - Debug: S->C: Client 1: ErrorResponse len: 348
13:19:08 - Error: Got error level: Error Message: ...
(client continues to perform execution)
13:19:08 - Debug: C->S: Client 1: Parse len: 120
...

This PR adds a check for an error in the connection phase, propagating it as an exception if one is received.

quinchs commented 1 year ago

Closing as this behavior is implemented in #42