edgedb / edgedb-net

The official .NET client library for EdgeDB
https://edgedb.com
Apache License 2.0
82 stars 9 forks source link

Fix FSharp arguments being cached incorrectly #66

Closed quinchs closed 1 year ago

quinchs commented 1 year ago

Summary

The binding would attempt to globally cache the IsSome and GetValue method on FSharpOption<>, the issue is that this type is generic specific, meaning if you had different option types like option<int32> and option<bool> it would throw an argument exception because of the type mismatch.

This PR fixes that by removing this behavior completely, the IsSome and GetValue methods are retrieved every time per type.

Fixes #65