edgedb / edgedb-pkg

EdgeDB Release Packaging Toolkit
1 stars 2 forks source link

Fix cmake on Ubuntu 18.04 and CentOS 7 #105

Closed fantix closed 1 month ago

fantix commented 1 month ago

The new dependency sentencepiece requires cmake --parallel added in cmake 3.12, which is not coming with Ubuntu 18.04 or CentOS 7. Download or build our own cmake for such targets.

Sample run

fantix commented 1 month ago

sigh the CentOS 7 aarch64 build fails again

2024-08-12T20:34:06.5961881Z #6 21.54 Error: Package: devtoolset-11-toolchain-11.1-2.el7.aarch64 (centos-sclo-rh)
2024-08-12T20:34:06.5963034Z #6 21.54            Requires: devtoolset-11-gcc-c++
2024-08-12T20:34:06.5964129Z #6 21.54 Error: Package: devtoolset-11-toolchain-11.1-2.el7.aarch64 (centos-sclo-rh)
2024-08-12T20:34:06.5965640Z #6 21.54            Requires: devtoolset-11-gcc
2024-08-12T20:34:06.5966721Z #6 21.54 Error: Package: devtoolset-11-toolchain-11.1-2.el7.aarch64 (centos-sclo-rh)
2024-08-12T20:34:06.5967867Z #6 21.54            Requires: devtoolset-11-gcc-gfortran
2024-08-12T20:34:06.5969062Z #6 21.54 Error: Package: devtoolset-11-toolchain-11.1-2.el7.aarch64 (centos-sclo-rh)
2024-08-12T20:34:06.5970191Z #6 21.54            Requires: devtoolset-11-gdb
2024-08-12T20:34:06.5971153Z #6 21.54  You could try using --skip-broken to work around the problem
2024-08-12T20:34:06.7093973Z #6 21.81  You could try running: rpm -Va --nofiles --nodigest
fantix commented 1 month ago

@elprans seems like we bumped the GCC_VERSION for CentOS 7 several times: up to 11, down to 10, up to 11 again, and looks like 11 is now gone in both centos.org and kernel.org mirrors (tho there is a 12 built but not included anywhere). What was the story here and shall we just use 10 for aarch64 and 11 for x86_64?

diff --git a/integration/linux/build/Dockerfile-linux.template b/integration/linux/build/Dockerfile-linux.template
index a37b798..d198d5e 100644
--- a/integration/linux/build/Dockerfile-linux.template
+++ b/integration/linux/build/Dockerfile-linux.template
@@ -19,7 +19,12 @@ ENV RUST_VERSION %%PLACEHOLDER%%
 ENV NODE_VERSION %%PLACEHOLDER%%
 ENV YARN_VERSION %%PLACEHOLDER%%
 ENV CMAKE_VERSION %%PLACEHOLDER%%
+%%IF VARIANT=aarch64%%
+ENV GCC_VERSION 10
+%%ENDIF%%
+%%IFNOT VARIANT=aarch64%%
 ENV GCC_VERSION 11
+%%ENDIF%%

 # rpm on centos 7 iterates over all fds up to the limit, which is
 # extremely slow. Force it to be small with limit.
elprans commented 1 month ago

What was the story here and shall we just use 10 for aarch64 and 11 for x86_64?

Inconsistent availability in the mirrors. Your proposal is fine.