search

edgedb / edgedb-pkg

EdgeDB Release Packaging Toolkit
1 stars 2 forks source link

macOS builds are broken #13

Closed elprans closed 4 years ago

elprans commented 4 years ago

The macOS EdgeDB build started failing with the below error for no apparent reason. Need to investigate and fix/workaround. Possibly, replace the use of rsync with an equivalent Python snippet.

2020-06-21T00:50:57.8742850Z rsync: writefd_unbuffered failed to write 4 bytes [sender]: Broken pipe (32)
2020-06-21T00:50:57.8743440Z ABORTING due to invalid path from sender: Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/lib/icu/current/Makefile.inc
2020-06-21T00:50:57.8744030Z rsync error: protocol incompatibility (code 2) at /AppleInternal/BuildRoot/Library/Caches/com.apple.xbs/Sources/rsync/rsync-54.120.1/rsync/generator.c(875) [generator=2.6.9]
2020-06-21T00:50:57.8744190Z rsync: connection unexpectedly closed (72 bytes received so far) [sender]
2020-06-21T00:50:57.8744760Z rsync error: error in rsync protocol data stream (code 12) at /AppleInternal/BuildRoot/Library/Caches/com.apple.xbs/Sources/rsync/rsync-54.120.1/rsync/io.c(453) [sender=2.6.9]
2020-06-21T00:50:57.8745270Z gmake: *** [Makefile:9: _artifacts/tmp/stamp/build] Error 12
2020-06-21T00:50:57.8757060Z env -u MAKELEVEL /usr/local/bin/gmake -j4 SHELL=/usr/local/bin/bash failed with exit code 2
ambv commented 4 years ago

Build is fixed but found another problem: for some reason ln -sf /Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/edgedb-server _artifacts/install/edgedb-server/Library/Frameworks/EdgeDB.framework/bin/edgedb-server-1-alpha4 doesn't work and that path in the file list ends up being invalid.

I removed the unversioned shim from the package. I need to replace it with the versioned symlink before closing this.

ambv commented 4 years ago

The symlink problem is fixed. The test nightly run failed on running tests though (the server didn't turn up). I'll be starting another run when edgedb/edgedb#1518 is merged.

ambv commented 4 years ago

I'm looking at the successful run and it still took over 6 seconds for the server to start. We time out at 10. Maybe we should allow for a longer timeout?

elprans commented 4 years ago

Sure, let's give it 20 for a better margin.