edgedb / edgedb-pkg

EdgeDB Release Packaging Toolkit
1 stars 2 forks source link

MacOS package no longer contain a symlink in `EdgeDB.framework/bin` #15

Closed tailhook closed 4 years ago

tailhook commented 4 years ago
> pkgutil --files com.edgedb.edgedb-server-1-alpha4 | grep /bin/
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/edgedb
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/edgedb-old
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/edgedb-server
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/initdb
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/pg_config
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/pg_ctl
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/postgres
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/psql
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/pygmentize
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/python3
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/python3-config
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/python3.8
Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/python3.8-config
ambv commented 4 years ago

This is fixed in the package:

Screenshot 2020-07-13 16 56 40

The problem is that it fails to publish due to failing tests. I'm looking at this now.

ambv commented 4 years ago

The test tries to run "/Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/edgedb-server-1-alpha4" which as you can see is not there.

ambv commented 4 years ago

Looks like the Linux test-published phase has a similar problem, too 🤦🏻‍♂️

ambv commented 4 years ago

Ha, @elprans committed a fix for this yesterday. As soon as GHA stops blowing up due to unrelated reasons, this should build cleanly.

tailhook commented 4 years ago

Looks like this is fixed.