search

edgedb / edgedb-rust

The official Rust binding for EdgeDB
https://edgedb.com
Apache License 2.0
213 stars 26 forks source link

update docs #224

Closed wylited closed 1 year ago

wylited commented 1 year ago

I was using this library and got confused for a while that the documentation was telling me to use edgedb_client in the documentation. So I just added the changes to make it normal.

(this does also require you to import edgedb-protocol as well, might be worth mention in the documentation, let me know if it is and I can also change that.)

thanks

edgedb-cla[bot] commented 1 year ago

All commit authors signed the Contributor License Agreement.
CLA signed

tailhook commented 1 year ago

(this does also require you to import edgedb-protocol as well, might be worth mention in the documentation, let me know if it is and I can also change that.)

Yes, feel free to add. This has to be fixed eventually, but there are few issues to figure out before that can be done.

wylited commented 1 year ago

regarding this comment, https://github.com/edgedb/edgedb-rust/pull/224/commits/55222989e95dd7fae013178181dd32bcabbef14f, why were they previously std::int32 and std::int64. I think this may have been causing when I tried to query it as a f32?

tailhook commented 1 year ago

regarding this comment, 5522298, why were they previously std::int32 and std::int64. I think this may have been causing when I tried to query it as a f32?

Oh, definitely a typo.

Would you mind signing CLA?

Dhghomon commented 1 year ago

@wylited I see this hasn't been merged yet, merging now. Thanks for the fix!