Always respect EDGEDB_CLOUD_PROFILE when connecting to cloud

edgedb / edgedb-rust

The official Rust binding for EdgeDB

https://edgedb.com

Apache License 2.0

214 stars 26 forks source link

Always respect EDGEDB_CLOUD_PROFILE when connecting to cloud #235

Closed elprans closed 11 months ago

elprans commented 1 year ago

Cloud instances, unlike local instances, do not represent local configuration, so EDGEDB_CLOUD_PROFILE should always be respected when connecting to such instances regardless of how compound connection options have been specified.

fantix commented 1 year ago

But we should probably also have a shared test case to cover this issue.

fwiw you can revert https://github.com/edgedb/shared-client-testcases/pull/22 to get at least one test case for EDGEDB_CLOUD_PROFILE I think, if we decided to proceed on with this PR.

elprans commented 11 months ago

But we should probably also have a shared test case to cover this issue.

fwiw you can revert edgedb/shared-client-testcases#22 to get at least one test case for EDGEDB_CLOUD_PROFILE I think, if we decided to proceed on with this PR.

Done in https://github.com/edgedb/shared-client-testcases/pull/29