edgedb / edgedb-rust

The official Rust binding for EdgeDB
https://edgedb.com
Apache License 2.0
214 stars 26 forks source link

Lowercase instance and org name when computing instance DNS #255

Closed elprans closed 1 year ago

elprans commented 1 year ago

Nebula switched to doing this, and so the clients must follow.

tailhook commented 1 year ago

I think we should lowercase them in the constructor of InstanceName so that comparison works well if/when we need it.

elprans commented 1 year ago

I think it's better to lowercase in constructor. This will make comparison and collections over instance names work fine. Unfortunately, this also means hiding the internal structure for the type.

Yes, but that's a much bigger change. Let's merge this fix and then follow up on a general cleanup/generalization of instance handling.