edgedb / edgedb-rust

The official Rust binding for EdgeDB
https://edgedb.com
Apache License 2.0
214 stars 26 forks source link

Implement From<bool> trait for Value #265

Closed hongquan closed 1 year ago

edgedb-cla[bot] commented 1 year ago

All commit authors signed the Contributor License Agreement.
CLA signed

Dhghomon commented 1 year ago

Hi @hongquan, I'd been meaning to add a few From impls and had just merged another PR of mine so thought I would do it separately on a branch from master which includes the From you suggested. Thanks!

https://github.com/edgedb/edgedb-rust/commit/67f89b31ee5518611a788d3842f01be2eba9eb48#diff-87d4558ffc6631071aadde9c152899530882adabb3428350c3c4f054d0d3a985R168

hongquan commented 1 year ago

Thanks