search

edgedb / edgedb-rust

The official Rust binding for EdgeDB
https://edgedb.com
Apache License 2.0
209 stars 26 forks source link

disable autoformatting #290

Closed dustypomerleau closed 2 months ago

dustypomerleau commented 5 months ago

Thanks for all your hard work on EdgeDB!

It would reduce friction for potential contributors if IDE autoformatting did not need to be disabled to interact with the codebase. Based on #245, I have the impression that you would prefer not to use rustfmt. This PR would formally disable rustfmt so that contributors don't have to suppress formatting on save.

edgedb-cla[bot] commented 5 months ago

All commit authors signed the Contributor License Agreement.
CLA signed

MrFoxPro commented 4 months ago

I think we should enforce some formatter. If Edgedb team want to receive open-source contributions, it's better to enforce some style, so all will be equally unhappy 😄

@raddevon @elprans

dustypomerleau commented 3 months ago

I think we should enforce some formatter. If Edgedb team want to receive open-source contributions, it's better to enforce some style, so all will be equally unhappy 😄

@raddevon @elprans

Using rustfmt would definitely be my preferred outcome, because adopting these conventions encourages the Rust community to take an interest in EdgeDB (not just the client library, but the main DB repo as well). Since the amount of Rust in the main database code seems likely to grow over time, it would be great to encourage that relationship.

dustypomerleau commented 2 months ago

Looks like #325 will close this. Thanks!

aljazerzen commented 2 months ago

That's right!

It looks like you are on top of your github notifications :D