edgedb / imdbench

IMDBench — Realistic ORM benchmarking
https://edgedb.github.io/imdbench
Apache License 2.0
242 stars 24 forks source link

add edgedb-go #11

Closed fmoor closed 4 years ago

fmoor commented 4 years ago

I had to do the following to go get the golang driver while the repo is private.

git config --global url.git@github.com:.insteadOf https://github.com/
export GOPRIVATE=github.com/edgedb/edgedb-go
1st1 commented 4 years ago

I had to do the following to go get the golang driver while the repo is private.

Can you figure out how you can add that to https://github.com/edgedb/webapp-bench/blob/master/Makefile (perhaps the "go" target?)

fmoor commented 4 years ago

Can you figure out how you can add that to https://github.com/edgedb/webapp-bench/blob/master/Makefile (perhaps the "go" target?)

I can do that, but the git config part needs to be --global. Doing that in a Makefile feels invasive. I'll try to revert the config change or something :thinking:

1st1 commented 4 years ago

I can do that, but the git config part needs to be --global. Doing that in a Makefile feels invasive. I'll try to revert the config change or something 🤔

Wait.. you only need that because the repo is private? Let's just make it public ;)

fmoor commented 4 years ago

I was able to update the Makefile so that it works with a private repo. No git config update necessary.

1st1 commented 4 years ago

Awesome, thanks!