search

edgedb / nextjs-edgedb-auth-template

A minimal starter designed to help you get up and running with EdgeDB and Next.js quickly. It includes a basic setup for authentication, EdgeDB schema, and a UI to get you started.
https://nextjs-edgedb-auth-template-kappa.vercel.app
30 stars 8 forks source link

[RFC] Attempt to implement Google OAuth including getting profile email via PKCE #11

Closed clarkg closed 4 months ago

clarkg commented 4 months ago

@scotttrinh (idk why I can't assign somebody. thanks in advance!)

scotttrinh commented 4 months ago

Thanks for the PR! I don't think we'll probably merge something that is so provider-specific, but having some general functionality to demonstrate and figuring out the minimal amount of supporting utility functions, so I'll do some review on this and try help guide us toward something that will be useful for someone using any of our supported providers.

clarkg commented 4 months ago

@scotttrinh yeah thanks! I'm happy to contribute and merge as a side-effect, but as you know my motivation anyway is asking for help debugging this from our convo on https://discord.com/channels/841451783728529451/1260648055737290773

clarkg commented 4 months ago

@scotttrinh thank you, that worked! will close this PR but lmk if you'd like me to re-open and contribute this if helpful

scotttrinh commented 4 months ago

@clarkg

Maybe we can have a function defined in this module that, given a tokenData will get some basic profile information and just comment that function heavily so that if someone was reading through the code, they could see how to get this kind of functionality?

Feel free to take a swing at add that, or I'm happy to add it to my todo list. Let me know either way. Thanks for jumping in here to contribute!