search

edgedb / rfcs

RFCs for major changes to EdgeDB
Apache License 2.0
35 stars 5 forks source link

[rfc-1] The RFC Process #3

Closed ambv closed 4 years ago

ambv commented 4 years ago

Pro tip: clicking on "Display the rich diff" allows for nicer preview of the ReST file in the "Files changed" tab on the pull request:

Screenshot 2020-02-04 16 14 24
1st1 commented 4 years ago

Let's merge this!

1st1 commented 4 years ago

Lukasz, can you also add an index of RFCs (currently 2) to the README?

ambv commented 4 years ago

Sure, will do.

On 5 Feb 2020, at 20:46, Yury Selivanov notifications@github.com wrote:

Lukasz, can you also add an index of RFCs (currently 2) to the README?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/edgedb/rfcs/pull/3?email_source=notifications&email_token=AAANP4MS2EQLR25GE2Z2O7TRBMJRHA5CNFSM4KPYT7PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4XLCI#issuecomment-582579593, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANP4O3VQGO5NND6A27VCTRBMJRHANCNFSM4KPYT7PA.

ambv commented 4 years ago

@elprans, @1st1 - sadly looks like a leading :: section is misrendered by GitHub as regular paragraph text just like the regular PEP metadata. I tried to name the :: section but it looks like the parser is looking for a title header first?

In this situation, should we go back to .. or remove the indentation altogether?