search

edgehog-device-manager / edgehog-device-runtime

Edgehog Device Runtime is a portable middleware written in Rust, that enables remote device management on Linux-based systems.
Apache License 2.0
11 stars 10 forks source link

feat(store): use SqliteStore, not MemoryStore #351

Closed rgallor closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 64.6%. Comparing base (c696202) to head (18ed899).

Additional details and impacted files | [Files](https://app.codecov.io/gh/edgehog-device-manager/edgehog-device-runtime/pull/351?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=edgehog-device-manager) | Coverage Δ | | |---|---|---| | [src/data/astarte\_device\_sdk\_lib.rs](https://app.codecov.io/gh/edgehog-device-manager/edgehog-device-runtime/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=edgehog-device-manager#diff-c3JjL2RhdGEvYXN0YXJ0ZV9kZXZpY2Vfc2RrX2xpYi5ycw==) | `34.2% <100.0%> (ø)` | | | [src/data/astarte\_message\_hub\_node.rs](https://app.codecov.io/gh/edgehog-device-manager/edgehog-device-runtime/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=edgehog-device-manager#diff-c3JjL2RhdGEvYXN0YXJ0ZV9tZXNzYWdlX2h1Yl9ub2RlLnJz) | `64.7% <100.0%> (ø)` | | | [src/lib.rs](https://app.codecov.io/gh/edgehog-device-manager/edgehog-device-runtime/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=edgehog-device-manager#diff-c3JjL2xpYi5ycw==) | `40.4% <ø> (+0.6%)` | :arrow_up: | | [src/data/mod.rs](https://app.codecov.io/gh/edgehog-device-manager/edgehog-device-runtime/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=edgehog-device-manager#diff-c3JjL2RhdGEvbW9kLnJz) | `63.6% <63.6%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/edgehog-device-manager/edgehog-device-runtime/pull/351/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=edgehog-device-manager)
joshuachp commented 3 months ago

Check the formatting, also the previous comment was for multiple places where you initialized a new temp directory. Not necessary to change it, but it would be nice while you are at it.