edgelesssys / constellation

Constellation is the first Confidential Kubernetes. Constellation shields entire Kubernetes clusters from the (cloud) infrastructure using confidential computing.
GNU Affero General Public License v3.0
906 stars 47 forks source link

operators: ignore node deletion errors on absence #3113

Closed burgerdev closed 1 month ago

burgerdev commented 1 month ago

Context

If a node deletion operation fails transiently after the instance was deleted at the CSP, we need to ensure that the retry succeeds, even if the instance we attempt to delete is already gone at the CSP.

Example operator logs: https://gist.github.com/burgerdev/c80de86ae44552a383364ef031243a41

Proposed change(s)

Additional info

Checklist

netlify[bot] commented 1 month ago

Deploy Preview for constellation-docs canceled.

Name Link
Latest commit 5949a5d329cb0b72e5f131e5bdee5b3a21cca770
Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/664cc07ce4e2070008434d91
github-actions[bot] commented 1 month ago

Coverage report

Package Old New Trend
operators/constellation-node-operator/internal/cloud/aws/client 34.40% 34.60% :arrow_upper_right:
operators/constellation-node-operator/internal/cloud/gcp/client 43.80% 43.90% :arrow_upper_right: