bootstrapper: disable gRPC logging

edgelesssys / constellation

Constellation is the first Confidential Kubernetes. Constellation shields entire Kubernetes clusters from the (cloud) infrastructure using confidential computing.

GNU Affero General Public License v3.0

939 stars 48 forks source link

bootstrapper: disable gRPC logging #3134

Closed msanft closed 4 months ago

msanft commented 4 months ago

Context

The bootstrapper vomits out a whole lot of gRPC debug logs, which don't seem very useful.

Proposed change(s)

Remove the debug flag.

Checklist

[ ] Run the E2E tests that are relevant to this PR's changes
[x] Add labels (e.g., for changelog category)
[x] Is PR title adequate for changelog?
[x] Link to Milestone

netlify[bot] commented 4 months ago

Deploy Preview for constellation-docs canceled.

Name	Link
Latest commit	3f084095f19ba60c6bd11cfab7347e522924f647
Latest deploy log	https://app.netlify.com/sites/constellation-docs/deploys/665f2a808f47920008a38ab7

daniel-weisse commented 4 months ago

Lets just remove the debug flag instead. The verbosity flag already does what the new debug flag does, but with more configuration options.

daniel-weisse commented 4 months ago

The upgrade agent also uses the debug flag, and we will need new debug images for this to run correctly in our e2e tests

github-actions[bot] commented 4 months ago

Coverage report

Package	Old	New	Trend
bootstrapper/cmd/bootstrapper	0.00%	0.00%	:construction:
upgrade-agent/cmd	0.00%	0.00%	:construction: