edgelesssys / constellation

Constellation is the first Confidential Kubernetes. Constellation shields entire Kubernetes clusters from the (cloud) infrastructure using confidential computing.
GNU Affero General Public License v3.0
903 stars 47 forks source link

ci: make cdbg deploy errors easier to spot #3168

Closed burgerdev closed 3 weeks ago

burgerdev commented 3 weeks ago

Context

We had a couple of failed cdbg deploy steps recently, which are incredibly hard to spot in the logs because they are hidden in the log group. Adding an explicit ::error:: should highlight them.

Proposed change(s)

Checklist

netlify[bot] commented 3 weeks ago

Deploy Preview for constellation-docs canceled.

Name Link
Latest commit 0775318d697aa5e38f0cac717fbb9804a4a04bc3
Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/666bf4373b29e80008a60ccf
burgerdev commented 3 weeks ago

Thanks for the review! I just realized that the || echo construction swallows the return code - does ::error:: fail the group regardless?

daniel-weisse commented 3 weeks ago

Pretty sure `echo "::error" only highlights the message in the action output