edgelesssys / constellation

Constellation is the first Confidential Kubernetes. Constellation shields entire Kubernetes clusters from the (cloud) infrastructure using confidential computing.
GNU Affero General Public License v3.0
939 stars 48 forks source link

cli: fix unmarshalling of sev-snp attestation documents in `constellation verify` #3171

Closed daniel-weisse closed 3 months ago

daniel-weisse commented 3 months ago

Context

attDoc.Attestation.TeeAttestation is an interface, so json.Unmarshal can't parse data into it by default. https://github.com/edgelesssys/constellation/pull/3164 removed a custom type from the constellation verify code in favor of using vtpm.AttestationDocument. The custom type replaced the interface with a concrete *attest.Attestation_SevSnpAttestation to circumvent the parsing issue.

Proposed change(s)

Related issue

Checklist

netlify[bot] commented 3 months ago

Deploy Preview for constellation-docs canceled.

Name Link
Latest commit 0e714d8dd262b53c3ee3104561ca2b173900a82e
Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6670010ec3202d0008732b58
github-actions[bot] commented 3 months ago

Coverage report

Package Old New Trend
cli/internal/cmd 40.90% 41.00% :arrow_upper_right: