edgelesssys / constellation

Constellation is the first Confidential Kubernetes. Constellation shields entire Kubernetes clusters from the (cloud) infrastructure using confidential computing.
GNU Affero General Public License v3.0
903 stars 47 forks source link

debugd: daemonize logstash containers #3216

Closed burgerdev closed 6 days ago

burgerdev commented 6 days ago

Context

There is a race condition between starting the logcollection pods and waiting for them to become ready. If the cmd.Start() is not fast enough to create the container, podman wait will error out because it does not know about the container.

Proposed change(s)

Note that the logs of the podman containers either end up in OpenSearch (if everything is fine), or are not accessible (if logcollection is broken). Either way, the outcome is the same as before this change.

Additional info

Checklist

netlify[bot] commented 6 days ago

Deploy Preview for constellation-docs canceled.

Name Link
Latest commit 5dc7c7f708ecd9a163c2c9d90e258ef59c04eeb7
Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/667ead6311bc1d000813aa0e
github-actions[bot] commented 6 days ago

Coverage report

Package Old New Trend
debugd/internal/debugd/logcollector 6.10% 6.10% :construction: