edgelesssys / constellation

Constellation is the first Confidential Kubernetes. Constellation shields entire Kubernetes clusters from the (cloud) infrastructure using confidential computing.
GNU Affero General Public License v3.0
939 stars 48 forks source link

openstack: Fix a crash in the bootstrapper during node join discovery #3375

Closed 3u13r closed 1 week ago

3u13r commented 1 week ago

Context

The bootstrapper still likes to query any nodes in addition to the LB endpoint when searching for join endpoints.

Openstack has a catalog discovery feature that gets URL endpoints during authentication (see: https://github.com/jtopjian/gophercloud/blob/master/openstack/endpoint_location.go#L63). Since we did not set the region we received more endpoints than expected and some even invalid ones.

Proposed change(s)

Checklist

netlify[bot] commented 1 week ago

Deploy Preview for constellation-docs canceled.

Name Link
Latest commit 09875af5791486951b5749cddab72ca01f988f62
Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/66f2b10e0a93dd00070fd0a5
github-actions[bot] commented 1 week ago

Coverage report

Package Old New Trend
internal/cloud/openstack 86.60% 84.40% :arrow_lower_right:
3u13r commented 1 week ago

I also not remember the actual crash location. I'll spin up a cluster to document this more thoroughly.