search

edgelesssys / contrast

Deploy and manage confidential containers on Kubernetes
https://docs.edgeless.systems/contrast
GNU Affero General Public License v3.0
160 stars 6 forks source link

manifest: add utilities for encrypted SeedShares #590

Closed burgerdev closed 1 week ago

burgerdev commented 1 week ago

This centralizes the algorithms used for managing seed shares and owner keys.

katexochen commented 1 week ago

I don't like how this change puts business logic into a pure crypto library. Imo the package shouldn't be aware of seed shares or import the api packages. Maybe we can move this somewhere else? Could be part of the manifest or the userapi.

burgerdev commented 1 week ago

My first pick would have been the userapi package, but you can make a similar argument there (it's a pure transport layer package). Manifest sounds good.

burgerdev commented 1 week ago

Fixed, ptal.