search

edgemesh / crux.run

The Chrome Real User Experience (CrUX) Database ... but faster
MIT License
7 stars 3 forks source link

Dotted lines that separate "fast-average-slow" areas are not in place. #4

Closed opusdei closed 5 years ago

opusdei commented 5 years ago

I think that the lines that separate the three areas: fast, average and slow are not drawn at the correct points. Attached is an image of the result, and of what it should be, according to the data. As you can see, there are "fast loading" time points within the "average loading time" range; and "average" points in the "slow" range.

Current drawing:

imagen

Corrected drawing:

imagen

jacobloveless commented 5 years ago

@opusdei Thanks for reporting this!

On Mon, Sep 9, 2019 at 2:50 AM opusdei notifications@github.com wrote:

I think that the lines that separate the three areas: fast, average and slow are not drawn at the correct points. Attached is an image of the result, and of what it should be, according to the data. As you can see, there are "fast loading" time points within the "average loading time" range; and "average" points in the "slow" range.

Current drawing:

[image: imagen] https://user-images.githubusercontent.com/5907868/64520512-9f6cb480-d2f6-11e9-9c6f-028f8032cc1b.png

Corrected drawing:

[image: imagen] https://user-images.githubusercontent.com/5907868/64521174-cd9ec400-d2f7-11e9-81f7-4b422916719d.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/edgemesh/crux.run/issues/4?email_source=notifications&email_token=AE6P44UJYG5HTTUEMNRGUELQIYL4TA5CNFSM4IUZBR52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKD7PUA, or mute the thread https://github.com/notifications/unsubscribe-auth/AE6P44S7GYHBNHW5F3DYMWDQIYL4TANCNFSM4IUZBR5Q .

yrokhlin commented 5 years ago

So originally these ref lines were really only meant to be just a quick relative guide, but I can see where it would cause confusion. I removed the old reference lines and I have replaced them with axis specific notation lines, that will always point to the correct fast/slow values.

image

Also, the gradient should now correspond correctly to the actual value of the histogram, so it should now be functional instead of just aesthetic.

image

This should be live now on https://crux.run (although cache might take a few minutes)

jacobloveless commented 5 years ago

NIce @yrokhlin - closing now