port setuptools options to declarative config

[FelixSchwarz]

LGTM

some potential follow-up improvements (not sure what @hodgestar thinks about these):

• Do we need to list the "tests" packages? I think this ensures they are present in the final wheel which is not ideal (though they should be present in sdist!).
• How about also referencing the license text? (license_file = COPYING)

[eli-schwartz]

I thought about adding license_files = COPYING, but it's a bit extraneous. bdist_wheel already defaults to

if 'license_file' not in metadata and 'license_files' not in metadata:
    patterns = ('LICEN[CS]E*', 'COPYING*', 'NOTICE*', 'AUTHORS*')

However, now that I check again, it is only done for wheel, not for sdist, and the real reason COPYING is even in the sdist is due to MANIFEST.in, so... we can move it from MANIFEST.in to setup.cfg

[eli-schwartz]

I agree that tests should not really be included in the final wheel, but that's a separate topic. It should be sufficient to distribute them via MANIFEST.in, but you might also want to move them to a top-level tests/ directory.

[hodgestar]

Other than the small change I requested, looks good to me too.

I agree that moving tests into a tests/... folder would be good but is a separate topic (and should not happen in this PR :).

[FelixSchwarz]

I thought about adding license_files = COPYING, but it's a bit extraneous.

My main reason for requesting was that the license file would be present in the dist-info all the time. Also it potentially helps distro tooling which can automate python packaging better (at least in Fedora we require that the license file is declared separately so we can ensure it is always installed even if the operator chooses not to install documentation files).

[eli-schwartz]

It's been two days but the CI finally passed. ;)

[hodgestar]

Merged!

@eli-schwartz Thank you!