Closed kloczek closed 3 years ago
@kloczek Should be pretty straight forward to fix. Are you up for opening a PR for this? If so, I can review.
I'm not that good on doing such things .. sorry :P I'm just packaging many python modules as rpm packages and I'm trying to provide any possible feedback about what I'm able to spot :)
Thanks for point these out then. Hopefully me or someone else will find a moment to try fix them.
Fixed in #42. Thanks for reporting.
Just tested that patch and looks like still there are some warnings😋
[tkloczko@barrel SPECS]$ rpmbuild -ba --with check python-genshi.spec --nodeps
warning: Downloading https://github.com/edgewall/genshi//archive/0.7.5/python-genshi-0.7.5.tar.gz to /home/tkloczko/rpmbuild/SOURCES/python-genshi-0.7.5.tar.gz
warning: Downloading https://github.com/edgewall/genshi//commit/647b3ff3.patch#/python-genshi-Replace-deprecated-assertEquals-with-assertEqual.patch to /home/tkloczko/rpmbuild/SOURCES/python-genshi-Replace-deprecated-assertEquals-with-assertEqual.patch
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.FAWVD5
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ cd /home/tkloczko/rpmbuild/BUILD
+ rm -rf genshi-0.7.5
+ /usr/bin/gzip -dc /home/tkloczko/rpmbuild/SOURCES/python-genshi-0.7.5.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd genshi-0.7.5
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ /usr/bin/cat /home/tkloczko/rpmbuild/SOURCES/python-genshi-Replace-deprecated-assertEquals-with-assertEqual.patch
+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch
+ RPM_EC=0
++ jobs -p
+ exit 0
[..]
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.YJ9MZy
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ cd genshi-0.7.5
+ CFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none'
+ LDFLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,--gc-sections -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto=auto -flto-partition=none -fuse-linker-plugin'
+ PATH=/home/tkloczko/rpmbuild/BUILDROOT/python-genshi-0.7.5-4.1.fc35.x86_64/usr/bin:/usr/bin:/usr/sbin:/usr/local/sbin
+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-genshi-0.7.5-4.1.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-genshi-0.7.5-4.1.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/python3 -Bm pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.9, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: /home/tkloczko/rpmbuild/BUILD/genshi-0.7.5
plugins: forked-1.3.0, shutil-1.7.0, virtualenv-1.7.0, asyncio-0.14.0, expect-1.1.0, cov-2.11.1, mock-3.5.1, httpbin-1.0.0, xdist-2.2.1, flake8-1.0.7, timeout-1.4.2, betamax-0.8.1, pyfakefs-4.4.0, freezegun-0.4.2, flaky-3.7.0, cases-3.4.6, hypothesis-6.10.1, case-1.5.3, isort-1.3.0, aspectlib-1.5.2
collected 57 items
genshi/filters/tests/test_html.py ......................................................... [100%]
============================================================================= warnings summary =============================================================================
genshi/filters/html.py:357
/home/tkloczko/rpmbuild/BUILD/genshi-0.7.5/genshi/filters/html.py:357: DeprecationWarning: invalid escape sequence \s
u'[Uu][Rr\u0280][Ll\u029F]\s*\(([^)]+)').finditer
genshi/filters/i18n.py:983
/home/tkloczko/rpmbuild/BUILD/genshi-0.7.5/genshi/filters/i18n.py:983: DeprecationWarning: invalid escape sequence \[
data = data.replace('[', '\[').replace(']', '\]')
genshi/filters/i18n.py:983
/home/tkloczko/rpmbuild/BUILD/genshi-0.7.5/genshi/filters/i18n.py:983: DeprecationWarning: invalid escape sequence \]
data = data.replace('[', '\[').replace(']', '\]')
genshi/filters/i18n.py:1038
/home/tkloczko/rpmbuild/BUILD/genshi-0.7.5/genshi/filters/i18n.py:1038: DeprecationWarning: invalid escape sequence \[
part.replace('\[', '[').replace('\]', ']'),
genshi/filters/i18n.py:1038
/home/tkloczko/rpmbuild/BUILD/genshi-0.7.5/genshi/filters/i18n.py:1038: DeprecationWarning: invalid escape sequence \]
part.replace('\[', '[').replace('\]', ']'),
genshi/template/interpolation.py:34
/home/tkloczko/rpmbuild/BUILD/genshi-0.7.5/genshi/template/interpolation.py:34: DeprecationWarning: Flags not at the start of the expression '[uU]?[rR]?("""|\\\'\\\'\\' (truncated)
token_re = re.compile('%s|%s(?s)' % (
genshi/path.py:663
/home/tkloczko/rpmbuild/BUILD/genshi-0.7.5/genshi/path.py:663: DeprecationWarning: invalid escape sequence \d
_tokenize = re.compile('("[^"]*")|(\'[^\']*\')|((?:\d+)?\.\d+)|(%s)|([^%s\s]+)|\s+' % (
-- Docs: https://docs.pytest.org/en/stable/warnings.html
====================================================================== 57 passed, 7 warnings in 0.28s ======================================================================