search

edgewall / genshi

Python toolkit for generation of output for the web
http://genshi.edgewall.org
Other
86 stars 35 forks source link

Fix CPython 3.11 compatibility #56

Closed brandtbucher closed 2 years ago

brandtbucher commented 2 years ago

Fixes #43. Fixes #52.

brandtbucher commented 2 years ago

Hm, looks like CI isn't configured?

I ran the tests locally using 3.7, 3.8, 3.9, 3.10, and 3.11. All pass.

brandtbucher commented 2 years ago

CC @FelixSchwarz.

This issue is breaking pyperformance on CPython's main branch; happy to help out any way I can to get it back up and running!

FelixSchwarz commented 2 years ago

Thank you so much for this PR, looks good to me. I'm sorry that it took so long until you got a response but I'll try to help you getting this landed (unless Simon beats me to it).

Hm, looks like CI isn't configured?

CI might be restricted to actual commits in the main repo as it contains deployment keys or so. @hodgestar knows more about this.

hodgestar commented 2 years ago

@brandtbucher This looks good -- thank you!

The CI tests are not running because I forgot to put a , pull_request in on: [pull] in the GitHub actions file. It's been added in #57. We can either wait a bit for #57 to land and then merge master into this PR or just add , pull_request here too and deal with the merge conflict later.

I'd like to run tests on CI before merging to avoid anything odd happening.

hodgestar commented 2 years ago

@brandtbucher -- #57 has been merged, so if you can merge master into your branch, then I can run the CI tests on this PR.

brandtbucher commented 2 years ago

There you go! Just need maintainer approval to run CI.

hodgestar commented 2 years ago

@brandtbucher Thank you! Tests passed in CI. Merging.

brandtbucher commented 2 years ago

Any idea when we can expect a release with this support included, @hodgestar?

FelixSchwarz commented 2 years ago

Any idea when we can expect a release with this support included, @hodgestar?

Yeah, having a Python 3.11 compatible release would be nice as this would also simplify Fedora 36 packaging. I think F36 will start a Python 3.11 mass rebuild in February.

hodgestar commented 2 years ago

Any idea when we can expect a release with this support included, @hodgestar?

I've finally found some time to rewrite the old Travis deployment using GitHub Actions. The PR for it is https://github.com/edgewall/genshi/pull/61. Once that is working we can do a new release.

See also #60.