edgexfoundry-holding / device-bluetooth-c

Apache License 2.0
5 stars 4 forks source link

Please clarify inclusion of attribution.txt #5

Closed tonyespy closed 4 years ago

tonyespy commented 5 years ago

I'm not super familiar with CMake, but it looks to me like this device service is still using dynamic libraries vs. statically linking against the SDK and libdbus. If so, then there's no need to add a top-level attribution.txt (which is typically only needed for static linking), instead you should copy the copyright and/or license files from the Alpine dbus package into your container. These are usually copied to /usr/share/doc/.

FraserG01 commented 4 years ago

completed: edgexfoundry-holding/device-bluetooth-c/pull/9