edgexfoundry / app-functions-sdk-go

Owner: Applications WG
Apache License 2.0
43 stars 83 forks source link

fix: Remove attempt to connect to the MessageBus from trigger #1498

Closed lenny-goodell closed 1 year ago

lenny-goodell commented 1 year ago

This is now handled by the MessageBus bootstrap handler.

closes #1479

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

build ASC with NATS capability locally (non-docker) with this branch of the SDK

NATS

Build edgex-go Docker with NATS capability Build Device Virtual Docker for NATS Run non-secure EdgeX stack with NATS Bus

make run ds-virtual no-secty nats-bus

Stop app-rules-engine container Verify app-rules-engine no longer fails with "already connected to NATS" message Run ASC with NATS locally

./app-service-configurable -cp -d -p rules-engine

Verify app-rules-engine (ASC) bootstraps w/o error

Redis

Run non-secure EdgeX stack with REDIS Bus Stop app-rules-engine container

make run ds-virtual no-secty app-dev

Run ASC with NATS locally

./app-service-configurable -cp -d -p rules-engine

Verify app-rules-engine (ASC) bootstraps w/o error

MQTT

Run non-secure EdgeX stack with MQTT Bus Stop app-rules-engine container

make run ds-virtual no-secty app-dev mqtt-bus

Verify app-rules-engine bootstraps w/o error

New Dependency Instructions (If applicable)