edgexfoundry / app-functions-sdk-go

Owner: Applications WG
Apache License 2.0
43 stars 83 forks source link

feat: Add retry on success capability for Store and Forward #1536

Closed lenny-goodell closed 10 months ago

lenny-goodell commented 10 months ago

closes #1526

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

Run non-secure Edgex stack with Device Rest and MQTT Broker from compose builder

make run no-secty ds-rest mqtt-broker

Build ASC with this branch of APP SDK Modify the ASC mqtt-export profile as follows:

New Dependency Instructions (If applicable)

codecov-commenter commented 10 months ago

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (0f93857) 66.63% compared to head (131e15b) 66.27%.

Files Patch % Lines
internal/runtime/storeforward.go 47.16% 26 Missing and 2 partials :warning:
internal/appfunction/context.go 0.00% 6 Missing :warning:
internal/runtime/runtime.go 50.00% 2 Missing and 1 partial :warning:
pkg/transforms/mqttsecret.go 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1536 +/- ## ========================================== - Coverage 66.63% 66.27% -0.36% ========================================== Files 36 36 Lines 3198 3238 +40 ========================================== + Hits 2131 2146 +15 - Misses 929 951 +22 - Partials 138 141 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lenny-goodell commented 10 months ago

@judehung, @cloudxxx8 , could you please review this PR and test it with your performance test to verify that it doesn't impact performance when data is being successfully exported. ie. the attempt to trigger retry after each successful send is minimal when there isn't any data stored to retry. Thanks!