Closed lenny-goodell closed 10 months ago
Attention: 39 lines
in your changes are missing coverage. Please review.
Comparison is base (
0f93857
) 66.63% compared to head (131e15b
) 66.27%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@judehung, @cloudxxx8 , could you please review this PR and test it with your performance test to verify that it doesn't impact performance when data is being successfully exported. ie. the attempt to trigger retry after each successful send is minimal when there isn't any data stored to retry. Thanks!
closes #1526
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Run non-secure Edgex stack with Device Rest and MQTT Broker from compose builder
Build ASC with this branch of APP SDK Modify the ASC mqtt-export profile as follows:
Run ASC with DEBUG logging
Verify Store and Forward started by checking for this log message.
Send "1234" to localhost:59986/api/v3/resource/sample-numeric/int using postman or curl Verify data was exported successfully via this log message
Verify Retry was not triggered since no failed data stored for retry. I.e. this message NOT in logs
Stop the MQTT Broker Send "1234" to localhost:59986/api/v3/resource/sample-numeric/int using postman or curl 5 times Verify each was saved for later retry
Stop ASC Restart MQTT Broker Restart ASC Verify Store and Forward started and has 5 items stored for retry.
Send "1234" to localhost:59986/api/v3/resource/sample-numeric/int using postman or curl Verify data was exported successfully via this log message
Verify the successful send triggered the retry of failed items.
Send "1234" to localhost:59986/api/v3/resource/sample-numeric/int using postman or curl on final time Verify data was exported successfully via this log message
Verify Retry was not triggered since no failed data stored for retry. I.e. this message NOT in logs
New Dependency Instructions (If applicable)