edgexfoundry / app-service-configurable

Owner: Applications WG
Apache License 2.0
18 stars 47 forks source link

refactor!: Replace internal topics from config with new constants and use base topic #520

Closed lenny-goodell closed 1 year ago

lenny-goodell commented 1 year ago

BREAKING CHANGE: Internal topics no longer configurable, except the base topic. Trigger topics for edgex-messagebus and external-mqtt now directly under Trigger section. All configured topics (subscribe and function pipeline) now automatically have the base topic (default of "edgex/") prepended.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-service-configurable/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

Run non-secure edgex stack with Device Virtual and MQTT Broker build ASC from this branch with -o -cp options Run ASC with each profile (skip push-to-core and functional-tests) Verify from logs that data is flowing from Device Virtual for the following profiles