edgexfoundry / app-service-configurable

Owner: Applications WG
Apache License 2.0
18 stars 47 forks source link

refactor!: Renamed SecretName to SecretValueKey and SecretnPath to SecretName #529

Closed marcpfuller closed 1 year ago

marcpfuller commented 1 year ago

BREAKING CHANGE: Renamed SecretName to SecretValueKey and SecretPath to SecretName

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-service-configurable/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

make test startup edgex run each profile individually to verify each started up successfully and are functioning correctly run ./app-service-configurable -p sample -cp run ./app-service-configurable -p mqtt-export -cp run ./app-service-configurable -p http-export -cp run ./app-service-configurable -p functional-tests -cp run ./app-service-configurable -p metrics-influxdb -cp run ./app-service-configurable -p rules-engine -cp

New Dependency Instructions (If applicable)

lenny-goodell commented 1 year ago

@marcpfuller , for testing, make test doesn't do much as there are not any unit tests. You need to run ASC with each profile and a at minimum verify they each start-up.

marcpfuller commented 1 year ago

@marcpfuller , for testing, make test doesn't do much as there are not any unit tests. You need to run ASC with each profile and a at minimum verify they each start-up.

I just ran through each profile and all ran without issue