snap build job doesn't properly fail on incorrect shas of downloaded snaps - Githubissues

edgexfoundry / ci-management

Control repo for Jenkins job and build minion definitions | Owner: DevOps WG

Apache License 2.0

10 stars 34 forks source link

snap build job doesn't properly fail on incorrect shas of downloaded snaps #517

Open anonymouse64 opened 4 years ago

anonymouse64 commented 4 years ago

See for example the log from this job:

22:26:13 [91msha512sum: WARNING: 1 computed checksum did NOT match
22:26:13 [0mcore.snap: FAILED
22:26:13 Parallel unsquashfs: Using 4 processors
22:26:13 [91mRead on filesystem failed because EOF
22:26:13 read_uids_guids: failed to read id index table
22:26:13 FATAL ERROR:failed to uid/gid table
22:26:13 [0mcore18.snap: OK

the job still goes on to try to run and fails for other unknown reasons.

anonymouse64 commented 4 years ago

Probably somewhere in this block of code we are not failing on non-0 exit codes:

https://github.com/edgexfoundry/ci-management/blob/7bf3d266df47637bd4e9f0d66110652baa77ab18/shell/edgexfoundry-snapcraft.sh#L134-L148

probably just a set -e at the start would do the trick