edgexfoundry / ci-management

Control repo for Jenkins job and build minion definitions | Owner: DevOps WG
Apache License 2.0
10 stars 34 forks source link

Set Go Version to 1.13x in Verify Jobs #567

Closed tsconn23 closed 4 years ago

tsconn23 commented 4 years ago

It appears the following job is configured to use Go 1.11.x.

https://jenkins.edgexfoundry.org/job/edgex-go-master-verify-go/configure

If you scroll down to the Build section, you'll see the following

Screen Shot 2020-02-06 at 9 05 11 AM

The request is to bump the referenced version of Go to 1.13.x in this verification pipeline and to check all other Go-based project pipelines for same.

This is in preparation for moving the project to Go 1.13 per agreed upon Geneva deliverable https://wiki.edgexfoundry.org/display/FA/Geneva+Release

ernestojeda commented 4 years ago

@tsconn23 Should we also bump the Go version in each of the Dockerfile's in the cmd folder. For example:

https://github.com/edgexfoundry/edgex-go/blob/master/cmd/config-seed/Dockerfile#L19 https://github.com/edgexfoundry/edgex-go/blob/master/cmd/core-command/Dockerfile#L9 https://github.com/edgexfoundry/edgex-go/blob/master/cmd/core-metadata/Dockerfile#L9 ...etc

tsconn23 commented 4 years ago

@ernestojeda Yes, that can be done separately though.

tsconn23 commented 4 years ago

Dockerfile mods for core/support/SMA services https://github.com/edgexfoundry/edgex-go/issues/2341

tsconn23 commented 4 years ago

@ernestojeda Go version has been rev'ed in Dockerfiles. Are there follow-up action items from your end?

jamesrgregg commented 4 years ago

Checked the running pipeline and each arch build shows the correct go version 1.13 00:03:53.102 go version go1.13 linux/amd64 00:04:14.453 go version go1.13 linux/arm64

Running Pipeline is for most recent PR-2040 https://jenkins.edgexfoundry.org/view/EdgeX%20Foundry%20Project/job/edgexfoundry/job/edgex-go/view/change-requests/job/PR-2040/35/console

lranjbar commented 4 years ago

Closed as fixed.