search

edgexfoundry / ci-management

Control repo for Jenkins job and build minion definitions | Owner: DevOps WG
Apache License 2.0
10 stars 34 forks source link

Publish v1 API to Swagger and remove some variables #585

Closed cherrycl closed 4 years ago

cherrycl commented 4 years ago
  1. Remove isPrivate and API_VERSION variables. The API_VERSION will get from API file directly, and set the API to public when sending the API to SwaggerHub.
  2. Publish v1 API to SwaggerHub. Signed-off-by: Cherry Wang cherry@iotechsys.com Fix #579
cherrycl commented 4 years ago

@ernestojeda Would you please help to review this PR? Thank you.

ernestojeda commented 4 years ago

I am adding @lenny-intel to this review because he had some objections about removing isPrivate

cloudxxx8 commented 4 years ago

@ernestojeda and @lenny-intel let's discuss in tomorrow QA WG meeting about the isPrivate topic. If you can't join the call, we can still discuss in this issue.

cherrycl commented 4 years ago

Based on the discussion on this week's QA meeting, reset the API to private when publishing API to SwaggerHub. @ernestojeda @lenny-intel Please help to review this PR again. Thanks.

cloudxxx8 commented 4 years ago

@MightyNerdEric Cherry has addressed your change request. Could you please review again? Thanks.

cherrycl commented 4 years ago

Rebased.